[dpdk-dev] [PATCH] net/mlx4: fix Tx doorbell register unmap

Yongseok Koh yskoh at mellanox.com
Mon Apr 8 20:23:13 CEST 2019


If rdma-core library doesn't support remapping UAR registers, the register
shouldn't be unmapped on device stop.

Fixes: 0203d33a1059 ("net/mlx4: support secondary process")

Signed-off-by: Yongseok Koh <yskoh at mellanox.com>
---
 drivers/net/mlx4/mlx4.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c
index 252658fc6a..9bca0ce9cd 100644
--- a/drivers/net/mlx4/mlx4.c
+++ b/drivers/net/mlx4/mlx4.c
@@ -314,8 +314,10 @@ static void
 mlx4_dev_stop(struct rte_eth_dev *dev)
 {
 	struct mlx4_priv *priv = dev->data->dev_private;
+#ifdef HAVE_IBV_MLX4_UAR_MMAP_OFFSET
 	const size_t page_size = sysconf(_SC_PAGESIZE);
 	int i;
+#endif
 
 	if (!priv->started)
 		return;
@@ -329,6 +331,7 @@ mlx4_dev_stop(struct rte_eth_dev *dev)
 	mlx4_flow_sync(priv, NULL);
 	mlx4_rxq_intr_disable(priv);
 	mlx4_rss_deinit(priv);
+#ifdef HAVE_IBV_MLX4_UAR_MMAP_OFFSET
 	for (i = 0; i != dev->data->nb_tx_queues; ++i) {
 		struct txq *txq;
 
@@ -338,6 +341,7 @@ mlx4_dev_stop(struct rte_eth_dev *dev)
 		munmap((void *)RTE_ALIGN_FLOOR((uintptr_t)txq->msq.db,
 					       page_size), page_size);
 	}
+#endif
 }
 
 /**
-- 
2.11.0



More information about the dev mailing list