[dpdk-dev] [PATCH v1] lib/power: fix buffer overrun coverity issues

Hunt, David david.hunt at intel.com
Tue Apr 9 16:40:17 CEST 2019


On 9/4/2019 12:18 PM, Burakov, Anatoly wrote:
> On 09-Apr-19 10:22 AM, David Hunt wrote:
>> A previous change removed the limit of 64 cores by
>> moving away from 64-bit masks to char arrays. However
>> this left a buffer overrun issue, where the max channels
>> was defined as 64, and max cores was defined as 256. These
>> should all be consistently set to RTE_MAX_LCORE.
>>
>> The #defines being removed are CHANNEL_CMDS_MAX_CPUS,
>> CHANNEL_CMDS_MAX_CHANNELS, POWER_MGR_MAX_CPUS, and
>> CHANNEL_CMDS_MAX_VM_CHANNELS, and are being replaced
>> with RTE_MAX_LCORE for consistency and simplicity.
>>
>> Fixes: fd73630e95c1 ("examples/power: change 64-bit masks to arrays")
>>      Coverity issue: 337672
>> Fixes: fd73630e95c1 ("examples/power: change 64-bit masks to arrays")
>>      Coverity issue: 337673
>> Fixes: fd73630e95c1 ("examples/power: change 64-bit masks to arrays")
>>      Coverity issue: 337678
>
> No need to mention the same commit three times :)
>

The coverity output said to add this, so I was leaving nothing to 
chance... :)




More information about the dev mailing list