[dpdk-dev] [PATCH v2] drivers: dpaa: fix 'bman_pool' leak in dpaa_mbuf_create_pool
Li Qiang
liq3ea at 163.com
Tue Apr 9 16:56:21 CEST 2019
When 'rte_zmalloc' failed dpaa_mbuf_create_pool() forgets freeing
'bp' thus leading resource leak. This patch avoids this.
Spotted by Coverity: CID 337679
Signed-off-by: Li Qiang <liq3ea at 163.com>
---
drivers/mempool/dpaa/dpaa_mempool.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/mempool/dpaa/dpaa_mempool.c b/drivers/mempool/dpaa/dpaa_mempool.c
index 003081772..54cdf37e8 100644
--- a/drivers/mempool/dpaa/dpaa_mempool.c
+++ b/drivers/mempool/dpaa/dpaa_mempool.c
@@ -78,8 +78,10 @@ dpaa_mbuf_create_pool(struct rte_mempool *mp)
rte_dpaa_bpid_info = (struct dpaa_bp_info *)rte_zmalloc(NULL,
sizeof(struct dpaa_bp_info) * DPAA_MAX_BPOOLS,
RTE_CACHE_LINE_SIZE);
- if (rte_dpaa_bpid_info == NULL)
+ if (rte_dpaa_bpid_info == NULL) {
+ bman_free_pool(bp);
return -ENOMEM;
+ }
}
rte_dpaa_bpid_info[bpid].mp = mp;
--
2.17.1
More information about the dev
mailing list