[dpdk-dev] [PATCH] vhost: fix passing destroyed device to destroy callback

David Marchand david.marchand at redhat.com
Wed Apr 10 10:07:44 CEST 2019


On Wed, Apr 10, 2019 at 9:53 AM Ilya Maximets <i.maximets at samsung.com>
wrote:

> On 10.04.2019 10:24, David Marchand wrote:
> > For vhost maintainers, looking at vhost_user_add_connection, aren't we
> leaking a vid on errors ? either when new_connection notifier returns an
> error, or after calling destroy_connection.
>
> I think that you're right.
> I spotted that too yesterday while preparing this patch, just had no time
> to
> check deeper. It should be safe to call 'vhost_destroy_device' in these
> cases.
>

Yes, that's my understanding too.


-- 
David Marchand


More information about the dev mailing list