[dpdk-dev] [EXT] Re: [PATCH v2] app/test: replace TEST_SKIPPED with -ENOTSUP

Ayuj Verma ayverma at marvell.com
Wed Apr 10 14:33:23 CEST 2019


Hi Bruce,


Have you gone through patch-set v1<http://mails.dpdk.org/archives/dev/2019-April/128407.html>

What's your opinion on them.


Thanks and regards

Ayuj Verma


________________________________
From: Bruce Richardson <bruce.richardson at intel.com>
Sent: 09 April 2019 20:25:32
To: Ayuj Verma
Cc: akhil.goyal at nxp.com; fiona.trahe at intel.com; arkadiuszx.kusztal at intel.com; pablo.de.lara.guarch at intel.com; Shally Verma; Sunila Sahu; Kanaka Durga Kotamarthy; Arvind Desai; dev at dpdk.org
Subject: [EXT] Re: [dpdk-dev] [PATCH v2] app/test: replace TEST_SKIPPED with -ENOTSUP

External Email

----------------------------------------------------------------------
On Tue, Apr 09, 2019 at 05:03:39PM +0530, Ayuj Verma wrote:
> Return -ENOTSUP for unsupported tests
>
I disagree with this, since TEST_SKIPPED is the correct return value for
unsupported test conditions IMHO. If part of the current infrastructure
doesn't support that return value, I think the infrastructure should be
updated.

Ref: http://mesonbuild.com/Unit-tests.html#skipped-tests-and-hard-errors

/Bruce


More information about the dev mailing list