[dpdk-dev] [PATCH v2] kni: implement header_ops parse method

[Ferruh Yigit]

On 4/12/2019 6:12 PM, Igor Ryzhov wrote:
> Hi Ferruh,
> 
> I didn't test it with any special application, but FRR's ISIS works for me after
> the patch, and it didn't work before.

That is good enough, and by work you mean that you are able to get correct value
on 'sll_addr', right?

> 
> Igor
> 
> On Fri, Apr 12, 2019 at 5:53 PM Ferruh Yigit <ferruh.yigit at intel.com
> <mailto:ferruh.yigit at intel.com>> wrote:
> 
>     On 4/12/2019 3:52 PM, Ferruh Yigit wrote:
>     > On 4/10/2019 11:30 AM, Igor Ryzhov wrote:
>     >> It allows applications running packet sockets over KNI interfaces to get
>     >> source Ethernet addresses of packets received using recvfrom function.
>     >>
>     >> Signed-off-by: Igor Ryzhov <iryzhov at nfware.com <mailto:iryzhov at nfware.com>>
>     >
>     > Acked-by: Ferruh Yigit <ferruh.yigit at intel.com
>     <mailto:ferruh.yigit at intel.com>>
>     >
>     >
>     > Hi Igor,
>     >
>     > I tested this with a quick application on top of kni interfaces, that
>     reads and
>     > prints the 'sll_halen', but the last two bytes of the mac address are always
> 
>     I mean 'sll_addr', 'sll_halen' is right (6).
> 
>     > zero, it is quite possible that something is not right in the test app, but
>     > before spending any time on it, can you please confirm this is working
>     fine for you?
>     >
>