[dpdk-dev] [PATCH v8 2/4] meson: add infra to support machine specific flags
Thomas Monjalon
thomas at monjalon.net
Sat Apr 13 22:42:50 CEST 2019
13/04/2019 08:24, Jerin Jacob Kollanukkaran:
> > I was not confortable with this patch without being able to say why.
> > Yesterday I spent more time to understand and see what may be improved.
> > I agree it is late, so it won't block this patch for 19.05.
> > Do you agree this file can be improved?
>
> Moving to the all to static config file is an option but we lose the flexibility
> of runtime detecting the options and few of them are probing at runtime based
> on gcc versions and mcpu combination etc.
I think there is a misunderstanding.
I'm suggesting to symplify arrays by indexing only by machine name.
It should not change the behaviour.
> I am not expert in meson area and not sure meson/python has better data strcture for this other than
> list/array combo. If Bruce has any feedback on this, then we
> will try to prototype it.
>
> > Please would you like to look at reworking during next cycle?
> > Thanks
More information about the dev
mailing list