[dpdk-dev] [PATCH v3] power: update for handling fifo path string

Hunt, David david.hunt at intel.com
Mon Apr 15 17:50:40 CEST 2019


Hi Lukasz,

On 15/4/2019 11:01 AM, Lukasz Gosiewski wrote:
> From: Lukasz Krakowiak <lukaszx.krakowiak at intel.com>
>
> Removed doubled created fifo path string for channel info.
>
> ---
> v3:
> *improvement to coding style
>
> v2:
> * rebase to master changes
>
> Signed-off-by: Lukasz Krakowiak <lukaszx.krakowiak at intel.com>
> Signed-off-by: Lukasz Gosiewski <lukaszx.gosiewski at intel.com>
> ---
>   examples/vm_power_manager/channel_manager.c | 7 +++----
>   1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/examples/vm_power_manager/channel_manager.c b/examples/vm_power_manager/channel_manager.c
> index 0187f79ab..05c0eea44 100644
> --- a/examples/vm_power_manager/channel_manager.c
> +++ b/examples/vm_power_manager/channel_manager.c
> @@ -24,6 +24,7 @@
>   #include <rte_log.h>
>   #include <rte_atomic.h>
>   #include <rte_spinlock.h>
> +#include <rte_string_fns.h>
>   
>   #include <libvirt/libvirt.h>
>   
> @@ -362,8 +363,6 @@ setup_host_channel_info(struct channel_info **chan_info_dptr,
>   	chan_info->status = CHANNEL_MGR_CHANNEL_DISCONNECTED;
>   	chan_info->type = CHANNEL_TYPE_JSON;
>   
> -	fifo_path(chan_info->channel_path, sizeof(chan_info->channel_path));
> -
>   	if (open_host_channel(chan_info) < 0) {
>   		RTE_LOG(ERR, CHANNEL_MANAGER, "Could not open host channel: "
>   				"'%s'\n",
> @@ -563,8 +562,8 @@ add_host_channel(void)
>   				"channel '%s'\n", socket_path);
>   		return 0;
>   	}
> -	strlcpy(chan_info->channel_path, socket_path,
> -		sizeof(chan_info->channel_path));
> +	rte_strlcpy(chan_info->channel_path, socket_path, UNIX_PATH_MAX);
> +
>   	if (setup_host_channel_info(&chan_info, 0) < 0) {
>   		rte_free(chan_info);
>   		return 0;


I'm not seeing this patch in patchwork, I'm seeing the original v1 from 
Lukasz K. Can you try re-sending to mailing list? If it's not in 
patchwork, it won't get applied.

Rgds,
Dave.





More information about the dev mailing list