[dpdk-dev] [PATCH v8 02/14] bus/ifpga: add function for AFU search by name

[Xu, Rosen]

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas at monjalon.net]
> Sent: Tuesday, April 16, 2019 16:10
> To: Xu, Rosen <rosen.xu at intel.com>
> Cc: Yigit, Ferruh <ferruh.yigit at intel.com>; dev at dpdk.org; Zhang, Tianfei
> <tianfei.zhang at intel.com>; Wei, Dan <dan.wei at intel.com>; Pei, Andy
> <andy.pei at intel.com>; Yang, Qiming <qiming.yang at intel.com>; Wang,
> Haiyue <haiyue.wang at intel.com>; Chen, Santos <santos.chen at intel.com>;
> Zhang, Zhang <zhang.zhang at intel.com>; Lomartire, David
> <david.lomartire at intel.com>; Hu, Jia <jia.hu at intel.com>
> Subject: Re: [PATCH v8 02/14] bus/ifpga: add function for AFU search by
> name
> 
> 16/04/2019 04:50, Xu, Rosen:
> > From: Yigit, Ferruh
> > > > --- a/drivers/bus/ifpga/rte_bus_ifpga.h
> > > > +++ b/drivers/bus/ifpga/rte_bus_ifpga.h
> > > > @@ -120,6 +120,15 @@ struct rte_afu_driver {  }
> > > >
> > > >  /**
> > > > + * Find AFU by AFU name.
> > > > + *
> > > > + * @param name
> > > > + *   A pointer to AFU name string.
> > > > + */
> > > > +struct rte_afu_device *__rte_experimental
> > > > +rte_ifpga_find_afu_by_name(const char *name);
> > > > +
> > >
> > >
> > > Hi Rosen,
> > >
> > > This is the bus code, and only drivers will call it right? I think
> > > there is no intention to make this run by application code, the
> > > functions need to be exported because driver and bus are different
> libraries.
> > > If above correct, there is no point of making the function
> > > experimental, can drop the __rte_experimental tag, and update .map
> > > file to not use EXPERIMENTAL.
> >
> > Hi Ferruh,
> >
> > Just double confirm with you, if I follow this modification, there is one
> checkpatch error.
> 
> This is a warning, and Ferruh allows it in this case :)
> 

Okay Thomas.