[dpdk-dev] [PATCH v2] virtio: fix buffer leak on vlan insert

Maxime Coquelin maxime.coquelin at redhat.com
Wed Apr 17 09:16:54 CEST 2019



On 4/5/19 6:31 PM, Stephen Hemminger wrote:
> The function rte_vlan_insert may allocate a new buffer for the
> vlan header and return a different mbuf than originally passed.
> In this case, the stored mbuf in txm[] array could point to wrong
> buffer.
> 
> Fixes: dd856dfcb9e7 ("virtio: use any layout on Tx")
> Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
> ---
> v2 - catch a couple more places.
>       The virtio code needs some refactoring to not have 3 copies of same
>       loop...
> 
>   drivers/net/virtio/virtio_rxtx.c | 6 ++++++
>   1 file changed, 6 insertions(+)
> 

Reviewed-by: Maxime Coquelin <maxime.coquelin at redhat.com>

Thanks,
Maxime


More information about the dev mailing list