[dpdk-dev] [PATCH v2] raw/ifpga_rawdev: fix fd leak in rte fpga do pr
Xu, Rosen
rosen.xu at intel.com
Wed Apr 17 10:03:47 CEST 2019
> -----Original Message-----
> From: Pei, Andy
> Sent: Wednesday, April 17, 2019 15:16
> To: dev at dpdk.org
> Cc: Pei, Andy <andy.pei at intel.com>; Xu, Rosen <rosen.xu at intel.com>;
> Kovacevic, Marko <marko.kovacevic at intel.com>; liq3ea at 163.com;
> stable at dpdk.org
> Subject: [PATCH v2] raw/ifpga_rawdev: fix fd leak in rte fpga do pr
>
> In rte_fpga_do_pr() function, if 'stat' returns error,
> rte_fpga_do_pr() returns -EINVAL without closing the 'file_fd' that has been
> opened.
> After this patch, 'file_fd' is closed before rte_fpga_do_pr() returns -EINVAL
> when 'stat' returns error
>
> Coverity issue: 279441
> Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver")
> Cc: rosen.xu at intel.com
> Cc: marko.kovacevic at intel.com
> Cc: liq3ea at 163.com
> Cc: andy.pei at intel.com
> Cc: stable at dpdk.org
>
> Signed-off-by: Andy Pei <andy.pei at intel.com>
> ---
> ---
> drivers/raw/ifpga_rawdev/ifpga_rawdev.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
> b/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
> index da772d0..eff001b 100644
> --- a/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
> +++ b/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
> @@ -244,7 +244,8 @@
> if (ret) {
> IFPGA_RAWDEV_PMD_ERR("stat on bitstream file
> failed: %s\n",
> file_name);
> - return -EINVAL;
> + ret = -EINVAL;
> + goto close_fd;
> }
> buffer_size = file_stat.st_size;
> IFPGA_RAWDEV_PMD_INFO("bitstream file size: %zu\n", buffer_size);
> --
> 1.8.3.1
Acked-by: Rosen Xu <rosen.xu at intel.com>
More information about the dev
mailing list