[dpdk-dev] [PATCH] doc: fix interactive commands in testpmd guide

Iremonger, Bernard bernard.iremonger at intel.com
Wed Apr 17 11:25:23 CEST 2019


> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Tuesday, April 16, 2019 4:06 PM
> To: Babu Radhakrishnan, AgalyaX <agalyax.babu.radhakrishnan at intel.com>;
> dev at dpdk.org
> Cc: Pattan, Reshma <reshma.pattan at intel.com>; olivier.matz at 6wind.com;
> Iremonger, Bernard <bernard.iremonger at intel.com>
> Subject: Re: [dpdk-dev] [PATCH] doc: fix interactive commands in testpmd
> guide
> 
> On 4/16/2019 7:33 AM, Agalya Babu RadhaKrishnan wrote:
> > From: Agalya Babu RadhaKrishnan
> <agalyax.babu.radhakrishnan at intel.com>
> >
> > Added some missing documentation for interactive mode commands
> >
> > Fixes: 01b2092a5e ("testpmd: add dump commands for debug")
> > Fixes: caf05a1b86 ("app/testpmd: new command to dump log types")
> >
> > Signed-off-by: Agalya Babu RadhaKrishnan
> > <agalyax.babu.radhakrishnan at intel.com>
> 
<snip>

Hi Babu,

./dpdk/devtools/check-git-log.sh  -1
Line too long:
        Signed-off-by: Agalya Babu RadhaKrishnan <agalyax.babu.radhakrishnan at intel.com>
Is it candidate for Cc: stable at dpdk.org backport?
        doc: fix interactive commands in testpmd guide

I am not sure what can be done about the length of the signoff line.
The Cc: stable at dpdk.org  line should be added after the Fixes line.

Otherwise
 
Acked-by: Bernard Iremonger <bernard.iremonger at intel.com>



More information about the dev mailing list