[dpdk-dev] [PATCH v1] fix alphabetical ordering of headers

[Trahe, Fiona]

Hi Ayuj, Akhil,

From: Akhil Goyal [mailto:akhil.goyal at nxp.com]
Sent: Wednesday, April 17, 2019 10:58 AM
To: Ayuj Verma <ayverma at marvell.com>; Trahe, Fiona <fiona.trahe at intel.com>; Kusztal, ArkadiuszX <arkadiuszx.kusztal at intel.com>
Cc: Shally Verma <shallyv at marvell.com>; Sunila Sahu <ssahu at marvell.com>; Kanaka Durga Kotamarthy <kkotamarthy at marvell.com>; Arvind Desai <adesai at marvell.com>; dev at dpdk.org
Subject: Re: [PATCH v1] fix alphabetical ordering of headers


Hi Ayuj,

> -----Original Message-----
> From: Ayuj Verma [mailto:ayverma at marvell.com]
> Sent: Friday, April 12, 2019 8:03 AM
> To: akhil.goyal at nxp.com<mailto:akhil.goyal at nxp.com>; Kusztal, ArkadiuszX <arkadiuszx.kusztal at intel.com<mailto:arkadiuszx.kusztal at intel.com>>; Trahe, Fiona
> <fiona.trahe at intel.com<mailto:fiona.trahe at intel.com>>
> Cc: shallyv at marvell.com<mailto:shallyv at marvell.com>; ssahu at marvell.com<mailto:ssahu at marvell.com>; kkotamarthy at marvell.com<mailto:kkotamarthy at marvell.com>; adesai at marvell.com<mailto:adesai at marvell.com>;
> dev at dpdk.org<mailto:dev at dpdk.org>; Ayuj Verma <ayverma at marvell.com<mailto:ayverma at marvell.com>>
> Subject: [PATCH v1] fix alphabetical ordering of headers
>
> rte_crypto_sym.h is included prior to rte_crypto_asym.h
> in rte_crypto.h, which breaks alphabetical order.
>
> include rte_crypto_sym.h in rte_crypto_asym.h fixes this.
[Fiona] I presume you tried just swapping the order and it broke?
If something in rte_crypto_asym.h depends on something from rte_crypto_sym.h, it
probably shouldn't. What's the dependency and can/should it be moved to rte_crypto.h?
[Ayuj] it is enum rte_crypto_auth_algorithm which it import from sym.h. So do you suggest to move it to rte_crypto.h?

[Akhil] moving the enum is not a good idea. I believe we do not need this change at all. Keeping the headers in alphabetical order may be a preferred way,
But it should not be mandatory, there may be some dependencies like this.
[Fiona] I agree with not moving the enum, now that I understand the dependency.
Either no change or the original patch are fine with me.