[dpdk-dev] [PATCH v2] build: mention machine=default and its use in documentation

Luca Boccassi bluca at debian.org
Thu Apr 18 11:30:48 CEST 2019


On Wed, 2019-04-17 at 22:17 +0200, Thomas Monjalon wrote:
> 14/01/2019 14:41, Luca Boccassi:
> > Document the new value, as it's useful for distributions and users
> > who need to use a stable baseline -march
> > 
> > Signed-off-by: Luca Boccassi <
> > bluca at debian.org
> > >
> > Reviewed-by: Christian Ehrhardt <
> > christian.ehrhardt at canonical.com
> > >
> > ---
> > +NOTE: machine=default will use the minimum required -march on all
> > architectures
> > +regardless of the capabilities of the machine where the build is
> > happening.
> 
> This option is not really selecting the minimum but something which
> works
> on every flavours of the CPU architecture.
> For instance, on ARM it can select a cacheline of 128B to make it
> work
> with 64B and 128B micro-architectures.
> 
> After discussing with Bruce and Luca I was convinced that "default"
> is not a good name, and "machine=any" would be better.
> The name "default" may also refer, in some contexts, to the config
> of the basic/standard CPU design.
> Even worst, "default" is not the default machine in DPDK...
> 
> Today I am not sure what is the best meaningful name,
> and I tend to think that "default" is well understood by everyone.
> So I am OK to apply this patch, but please replace
> 	"minimum required -march"
> by
> 	"config working"
> or something similar, thanks.

No problem, updated in v3, thanks.

-- 
Kind regards,
Luca Boccassi


More information about the dev mailing list