[dpdk-dev] [PATCH] Revert "app/testpmd: set fixed flag for exact link speed"
Ferruh Yigit
ferruh.yigit at intel.com
Thu Apr 25 00:03:09 CEST 2019
This reverts commit bdca79053b6aea504d02691d9319fa976062457f.
Not all PMDs support the fixed link speed set, and link speed can be set
even with auto negotiation enabled. Reverting the patch to not break
existing usage.
Signed-off-by: Ferruh Yigit <ferruh.yigit at intel.com>
---
Cc: Andrew Rybchenko <arybchenko at solarflare.com>
Cc: WenjieX A Li <wenjiex.a.li at intel.com>
Cc: Bernard Iremonger <bernard.iremonger at intel.com>
Cc: Thomas Monjalon <thomas at monjalon.net>
---
app/test-pmd/cmdline.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index f45ef8a1c..c1042dd98 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -1533,17 +1533,17 @@ parse_and_check_speed_duplex(char *speedstr, char *duplexstr, uint32_t *speed)
return -1;
}
if (!strcmp(speedstr, "1000")) {
- *speed = ETH_LINK_SPEED_1G | ETH_LINK_SPEED_FIXED;
+ *speed = ETH_LINK_SPEED_1G;
} else if (!strcmp(speedstr, "10000")) {
- *speed = ETH_LINK_SPEED_10G | ETH_LINK_SPEED_FIXED;
+ *speed = ETH_LINK_SPEED_10G;
} else if (!strcmp(speedstr, "25000")) {
- *speed = ETH_LINK_SPEED_25G | ETH_LINK_SPEED_FIXED;
+ *speed = ETH_LINK_SPEED_25G;
} else if (!strcmp(speedstr, "40000")) {
- *speed = ETH_LINK_SPEED_40G | ETH_LINK_SPEED_FIXED;
+ *speed = ETH_LINK_SPEED_40G;
} else if (!strcmp(speedstr, "50000")) {
- *speed = ETH_LINK_SPEED_50G | ETH_LINK_SPEED_FIXED;
+ *speed = ETH_LINK_SPEED_50G;
} else if (!strcmp(speedstr, "100000")) {
- *speed = ETH_LINK_SPEED_100G | ETH_LINK_SPEED_FIXED;
+ *speed = ETH_LINK_SPEED_100G;
} else if (!strcmp(speedstr, "auto")) {
*speed = ETH_LINK_SPEED_AUTONEG;
} else {
--
2.20.1
More information about the dev
mailing list