[dpdk-dev] [PATCH] net/dpaa2: fix incorrect loop increment

Shreyansh Jain shreyansh.jain at nxp.com
Thu Apr 25 15:34:56 CEST 2019


Identified by LGTM, the loop was incorrectly incrementing a different
variable and conditional on another.

Fixes: fe2b986ac662 ("net/dpaa2: support generic flow")
Cc: sunil.kori at nxp.com

Suggested-by: Ferruh Yigit <ferruh.yigit at intel.com>
Signed-off-by: Shreyansh Jain <shreyansh.jain at nxp.com>
---
 drivers/net/dpaa2/dpaa2_flow.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/dpaa2/dpaa2_flow.c b/drivers/net/dpaa2/dpaa2_flow.c
index 98f68139b..9ef46d47e 100644
--- a/drivers/net/dpaa2/dpaa2_flow.c
+++ b/drivers/net/dpaa2/dpaa2_flow.c
@@ -1734,7 +1734,7 @@ dpaa2_dev_verify_patterns(struct dpaa2_dev_priv *dev_priv,
 	/* more	than DPKG_MAX_NUM_OF_EXTRACTS. Verify this limitation too. */
 	for (i = 0; pattern[i].type != RTE_FLOW_ITEM_TYPE_END; i++) {
 		for (j = 0; j < MAX_TCS + 1; j++) {
-				for (k = 0; k < DPKG_MAX_NUM_OF_EXTRACTS; j++) {
+				for (k = 0; k < DPKG_MAX_NUM_OF_EXTRACTS; k++) {
 					if (dev_priv->pattern[j].pattern_type[k] == pattern[i].type)
 						break;
 				}
-- 
2.17.1



More information about the dev mailing list