[dpdk-dev] [PATCH] app/pdump: exits once primary app exited

Varghese, Vipin vipin.varghese at intel.com
Thu Apr 25 17:51:16 CEST 2019


Hi,

snipped
> @@ -847,6 +847,10 @@ struct parse_val {
>  		pdump_rxtx(pt->rx_ring, pt->rx_vdev_id, &pt->stats);
>  	if (pt->dir & RTE_PDUMP_FLAG_TX)
>  		pdump_rxtx(pt->tx_ring, pt->tx_vdev_id, &pt->stats);
> +
> +	/* Once primary exits, so will I. */
> +	if (!rte_eal_primary_proc_alive(NULL))
> +		quit_signal = 1;
>  }

As per the current suggested code flow check is added to while loop in function `dump_packets'. 

Questions:
1. What is impact in performance with and without patch?
2. For various packet sizes and port speed what are delta in drops for packet capture?

Note: If pdump application is still alive when primary is not running, primary cannot be started. Is this a cue that pdump is still alive and has to be terminated?

> 
>  static int
> --
> 1.7.12.4



More information about the dev mailing list