[dpdk-dev] [PATCH v4] app/pdump: add pudmp exits with primary support.

Varghese, Vipin vipin.varghese at intel.com
Tue Apr 30 07:03:27 CEST 2019


snipped
> >
> > 1. the documentation update.
> 
> I'd like to reconfirm that since Anatoly suggested to make the option default, I
> deleted the option supporting code.
> 
> Is it aligned that we can make it default?
> 
> If it is aligned to make it default, then if I understand correctly, to add a new note
> in the documentation to describe pdump will exit with primary will be OK?

I am not aware of the conversation and will leave this to maintainer if the option should be `--exit-with-primary` or `--do-not-exit-primary`. 

Please add the changes to `doc/guides/tools/proc_info.rst` of the changes and new option that gets added.

> 
> > 2. cover letter.
> Sorry for that. Will add the cover letter in the V5 patch.
thanks

> > 3. for signal SIGINT, set for ` rte_eal_alarm_cancel`.
> Ah, yes.
Thanks

> >
> > Can you share a new patch as v5 with these changes?
> Thanks for your reviewing. I will send the next patch after Q1 confirmed.
Ok


snipped



More information about the dev mailing list