[dpdk-dev] [PATCH] net/mlx5: check Tx queue size overflow

[Stephen Hemminger]

On Tue, 30 Apr 2019 12:04:26 -0700
Yongseok Koh <yskoh at mellanox.com> wrote:

> +	    priv->sh->device_attr.orig_attr.max_qp_wr) {
> +		DRV_LOG(DEBUG,
> +			"port %u Tx WQEBB count exceeds the limit (%d),"
> +			" try smaller queue size again",
> +			dev->data->port_id,

The patch looks good, but it could be improved to make life easier
for the users.

This is an error, why not print it at NOTICE level since DEBUG messages
are usually suppressed.

Please don't break long lines in log messages. The latter part of the message
is obvious, why not skip it.

Also since max_qp_wr is __u32, the print format should be %u

Instead:
		DRV_LOG(NOTICE,
			"port %u Tx WQEBB count (%u) exceeds the limit (%u)",
			dev->data->port_id,
			txq_calc_wqebb_cnt(tmpl),
			priv->sh->device_attr.orig_attr.max_qp_wr);

Also, should it have a Fixes: tag to backport to stable?