[dpdk-dev] [dpdk-devPATCH v2 1/1] common/octeontx2: fix unaligned mbox memory accesses

Jerin Jacob Kollanukkaran jerinj at marvell.com
Fri Aug 2 07:57:14 CEST 2019


> -----Original Message-----
> From: vattunuru at marvell.com <vattunuru at marvell.com>
> Sent: Friday, August 2, 2019 9:50 AM
> To: dev at dpdk.org
> Cc: thomas at monjalon.net; Jerin Jacob Kollanukkaran <jerinj at marvell.com>;
> Vamsi Krishna Attunuru <vattunuru at marvell.com>; Nithin Kumar
> Dabilpuram <ndabilpuram at marvell.com>
> Subject: [dpdk-devPATCH v2 1/1] common/octeontx2: fix unaligned mbox
> memory accesses
> 
> From: Vamsi Attunuru <vattunuru at marvell.com>
> 
> Octeontx2 PMD's mailbox client uses device memory to send messages to
> mailbox server in the admin function Linux kernel driver.
> The device memory used for the mailbox communication needs to be
> qualified as volatile memory type to avoid unaligned device memory
> accesses because of compiler's memory access coalescing.
> 
> This patch modifies the mailbox request and responses as volatile type which
> were non-volatile earlier and accessed from unaligned memory addresses.

Please mention this bus error reported with Fedora 30 with gcc 9.1.1

> 
> Fixes: 2b71657c8660 ("common/octeontx2: add mbox request and response
> ")

Please fix below check-git-log.sh warnings

Wrong headline prefix:
        common/octeontx2: fix unaligned mbox memory accesses
Wrong 'Fixes' reference:
        Fixes: 2b71657c8660 ("common/octeontx2: add mbox request and response ")


> 
> Signed-off-by: Vamsi Attunuru <vattunuru at marvell.com>
> Signed-off-by: Nithin Dabilpuram <ndabilpuram at marvell.com>

With above change:

Acked-by: Jerin Jacob <jerinj at marvell.com>



More information about the dev mailing list