[dpdk-dev] [PATCH] net/mlx5: txq_inline_min not set for ConnectX-5 adapters

David Christensen drc at linux.vnet.ibm.com
Fri Aug 2 20:17:49 CEST 2019

>>> Yes, thank you for the patch, acked.
>>> The "txq_inline_min" value was not set for ConnectX-5 to 0 as default.
>>> At the TX queue setup time the "txq_inline_min" is checked against
>>> MLX5_ARG_UNSET and default value 0 is set:
>>> txq_set_params()
>>> ...
>>> inlen_mode = (config->txq_inline_min == MLX5_ARG_UNSET) ?
>>>                        0 : (unsigned int)config->txq_inline_min;
>>> So, there should be no negative backwards. Did you observe any?
>> The gdb session below shows how the value is unchanged after passing
>> through mlx5_set_min_inline on my system without the change.
> Yes, mlx5_set_min_inline() does not set txq_inline_min by default.
> So, your patch is OK.
> I mean the actual inline_len is set to 0 before actual usage in txq_set_params()
> routine, so not setting config->txq_inline_min to default zero should not cause
> negative backwards.

So that implies the assert to verify that txq_inline_min >= 0 in 
mlx5_set_txlimit_params() is unnecessary.  Should the patch change and 
just remove the assert?

I think the patch is the more logical solution, setting the value at the 
source similar to what's done for all other adapters.


More information about the dev mailing list