[dpdk-dev] [PATCH] build: avoid --as-needed as it causes overlinking

[Luca Boccassi]

On Wed, 2019-08-28 at 14:27 +0200, Christian Ehrhardt wrote:
> A while ago telemetry was added in 57ae0ec6 and it also added as-
> needed
> to config/meson.build. This seems no more needed these days as due to
> other
> build changes the ordering in buildlogs is:
>   [...] -lrte_telemetry [...] -Wl,--no-as-needed [...]
> Which means telemetry no more benefits from --no-as-needed anyway.
> 
> Overlinking problems get triggered by the meson generated pkgconfig
> which
> will have:
>    [...] -Wl,--no-as-needed <somelibsusedbydpdk>
> This will overlink <somelibs> and in addition anything that follows
> as it also doesn't wrap back to --as-needed. So if a projects
> includes
> dpdk libs + <other> it will also consider <other> with --no-as-
> needed.
> 
> Fixes: 
> https://bugs.launchpad.net/ubuntu/+source/dpdk/+bug/1841759
> 
> 
> Signed-off-by: Christian Ehrhardt <
> christian.ehrhardt at canonical.com
> >
> ---
>  config/meson.build | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/config/meson.build b/config/meson.build
> index 2bafea530..58800a980 100644
> --- a/config/meson.build
> +++ b/config/meson.build
> @@ -93,9 +93,6 @@ dpdk_conf.set('RTE_TOOLCHAIN_' +
> toolchain.to_upper(), 1)
>  
>  dpdk_conf.set('RTE_ARCH_64', cc.sizeof('void *') == 8)
>  
> -add_project_link_arguments('-Wl,--no-as-needed', language: 'c')
> -dpdk_extra_ldflags += '-Wl,--no-as-needed'
> -
>  # use pthreads
>  add_project_link_arguments('-pthread', language: 'c')
>  dpdk_extra_ldflags += '-pthread'
> 

Acked-by: Luca Boccassi <bluca at debian.org>

-- 
Kind regards,
Luca Boccassi