[dpdk-dev] [PATCH v3 00/17] Introduces net/ionic PMD

Ferruh Yigit ferruh.yigit at intel.com
Tue Dec 10 19:57:30 CET 2019


On 12/9/2019 9:46 PM, Alfredo Cardigliano wrote:
> The patch series provides an initial version of a
> poll mode driver for Pensando network adapters.
> The driver name is ionic.
> 
> v3 Changes:
> ----------
> - Set the license to BSD-3 (in addition to GPL-2)
> - Add the new PMD driver to the release notes
> - Add a link to the adapter vendor page
> - Cleanup the makefile (compilation flags, libraries, etc)
> - Fix clang build errors
> - Fix indentation according to the dpdk coding style
> - Cleanup log functions and macros
> - Set min/max mtu to be checked by the API
> - Uninitialize device in close dev_ops
> - Fix VLAN offload support
> - Initialize stats struct
> - Move structures size check
> - Other minor code cleanup
> 
> Signed-off-by: Alfredo Cardigliano <cardigliano at ntop.org>
> Reviewed-by: Shannon Nelson <snelson at pensando.io>
> 
> Alfredo Cardigliano (17):
>   net/ionic: add skeleton
>   net/ionic: add hardware structures definitions
>   net/ionic: add log
>   net/ionic: register and initialize the adapter
>   net/ionic: add port management commands
>   net/ionic: add basic lif support
>   net/ionic: add doorbells
>   net/ionic: add adminq support
>   net/ionic: add notifyq support
>   net/ionic: add basic port operations
>   net/ionic: add RX filters support
>   net/ionic: add Flow Control support
>   net/ionic: add RX and TX handling
>   net/ionic: add RSS support
>   net/ionic: add stats
>   net/ionic: add TX checksum support
>   net/ionic: read fw version

Hi Alfredo,

License issue still needs to be cleared.

There is shared build errors, I mentioned details in the patch, can you please
be sure shared build works in next version?

Also can you please run in-house scripts and be sure the issues they identified
are addressed:
./devtools/checkpatches.sh
./devtools/check-git-log.sh


And I already put some comments to the individual patches.


Thanks,
ferruh


More information about the dev mailing list