[dpdk-dev] [PATCH 1/2] net/ena: upgrade HAL for new HW features

[Stephen Hemminger]

On Fri, 13 Dec 2019 14:32:15 +0100
Michal Krawczyk <mk at semihalf.com> wrote:

> This version of the HAL allows to use the latest HW features, like
> rx offsets.
> 
> Driver was adjusted to the new version to fix the build.
> 
> Signed-off-by: Michal Krawczyk <mk at semihalf.com>
> Signed-off-by: Maciej Bielski <mba at semihalf.com>

You are mixing multiple changes into one patch.
This makes it harder to review (find the real bits) and also
harder for bisection.

It makes sense to fix whitespace and related stuff in one
patch if you are fixing one function and the nearby code
already needed work. But please avoid larger scale change
put together.

In your patch I see:
	- remove unnecessary whitespace
	- drop unnecessary inline
	- add missing newline in log messages
	- check for NULL pointer

If possible could you preserve the per-commit updates for base
code, rather than one lump diff.