[dpdk-dev] [PATCH v6 00/11] Add ABI compatibility checks to the meson build

David Marchand david.marchand at redhat.com
Fri Dec 20 14:19:13 CET 2019


On Fri, Dec 20, 2019 at 12:04 PM Bruce Richardson
<bruce.richardson at intel.com> wrote:
> > For maintainers that integrate patches or developers that get a CI
> > failure and want to fix it, we would need to help them to:
> > * generate dumps on a reference version, so I would tend to write some
> > documentation since playing with the current sources would be too
> > dangerous from my pov,
>
> This should be a one-off reference dump archived somewhere. Each maintainer
> should not have his own copy, I think.

This is not a one-off thing.
We maintain ABI for some time (1/2 year(s)), and we expect to bump ABI.
When doing this, in size, the diff will be at least the same than what
we have here.


If you disable libraries, features etc... you get a new ABI.
What would be the reference*s* then?
Builds with default options from meson for each architecture?


> > * run the checks, like adding the check in the
> > devtools/test-*-build.sh scripts that already exist, with a new
> > configuration item to point at the dumps per target,
> >
>
> Where do we store the dumps then? Do they get stored in a separate git
> repo?

Creating a separate git repo is just adding more pain to submitters
(/maintainers): they would have to submit (/apply) patches against two
trees.


--
David Marchand



More information about the dev mailing list