[dpdk-dev] [PATCH v2] drivers: fix to replace strcat with strncat

[Bruce Richardson]

On Thu, Feb 07, 2019 at 11:56:30AM +0000, Ferruh Yigit wrote:
> On 1/21/2019 10:43 AM, Parthasarathy, JananeeX M wrote:
> > 
> > 
> >> -----Original Message-----
> >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Chaitanya Babu Talluri
> >> Sent: Friday, January 18, 2019 8:54 PM
> >> To: dev at dpdk.org
> >> Cc: rmody at marvell.com; Pattan, Reshma <reshma.pattan at intel.com>;
> >> shshaikh at marvell.com; Xing, Beilei <beilei.xing at intel.com>; Zhang, Qi Z
> >> <qi.z.zhang at intel.com>; alejandro.lucero at netronome.com; De Lara Guarch,
> >> Pablo <pablo.de.lara.guarch at intel.com>; Doherty, Declan
> >> <declan.doherty at intel.com>; Chaitanya Babu, TalluriX
> >> <tallurix.chaitanya.babu at intel.com>; stable at dpdk.org
> >> Subject: [dpdk-dev] [PATCH v2] drivers: fix to replace strcat with strncat
> >>
> >> Strcat does not check the destination length and there might be chances of
> >> string overflow so insted of strcat, strncat is used.
> >>
> >> Fixes: 540a211084 ("bnx2x: driver core")
> >> Fixes: e163c18a15 ("net/i40e: update ptype and pctype info")
> >> Fixes: ef28aa96e5 ("net/nfp: support multiprocess")
> >> Fixes: 6f4eec2565 ("test/crypto: enhance scheduler unit tests")
> >> Cc: stable at dpdk.org
> >>
> >> Signed-off-by: Chaitanya Babu Talluri <tallurix.chaitanya.babu at intel.com>
> 
> <...>
> 
> > 
> > Any Review Please!!
> > 
> 
> cc'ed Bruce & Thomas.
> 
> What do you think getting strlcat() patch first and updating this patch to use
> strlcat()?
> 
> Are we OK to get strlcat as the default API?
> 
"strlcat" is just saner to use, so +1 for this approach.

/Bruce