[dpdk-dev] [PATCH 1/2] Enable codespell from config file.

[Bruce Richardson]

On Wed, Feb 13, 2019 at 07:16:24PM +0000, Van Haaren, Harry wrote:
> > -----Original Message-----
> > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Michael Santana
> > Sent: Wednesday, February 13, 2019 7:08 PM
> > To: dev at dpdk.org
> > Cc: Thomas Monjalon <thomas at monjalon.net>
> > Subject: [dpdk-dev] [PATCH 1/2] Enable codespell from config file.
> > 
> > Enable turning on codespell from any of the config files for
> > checkpatches.sh. codespell is a feature by checkpatch.pl that
> > checks for common spelling mistakes in comments in patches.
> > 
> > This feature is disabled by default. To enable it one must add
> > the '--codespell' flag to the $options variable in
> > checkpatches.sh. With this change the user can decide to turn
> > on codespell from a config file rather than directly modifying
> > checkpatches.sh
> > 
> > Signed-off-by: Michael Santana <msantana at redhat.com>
> 
> Oh nice, I didn't know checkpatch had a spell check available.
> 
> Would it make sense to turn on automatically if the required spelling program is available?
> 
> (Perhaps provide an explicit disable if certain people hate the idea..)
> 
> I'm a +1 for tools just doing the right thing by default :)
> 
+1 for on by default.