[dpdk-dev] [PATCH 3/5] app/testpmd: add missing transmit errors stats

Thomas Monjalon thomas at monjalon.net
Fri Feb 15 20:38:59 CET 2019


15/02/2019 19:42, Ananyev, Konstantin:
> >>> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of David Marchand
> >>> I am also for option 2 especially because of this.
> >>> A driver that refuses a packet for reason X (which is a limitation, or an
> >>> incorrect config or whatever that is not a transient condition) but gives
> >>> it back to the application is a bad driver.
> 
> >>Why? What.s wrong to leave it to the upper layer to decide what to
> >>do with the packets that can't be sent (by one reason or another)?
> 
> >How does the upper layer know if this is a transient state or something that can't be resolved?
> 
> Via rte_errno, for example.

rte_errno is not a result per packet.
I think it is better to "eat" the packet
as it is done for those transmitted to the HW.




More information about the dev mailing list