[dpdk-dev] [RFC v4] /net: memory interface (memif)

Stephen Hemminger stephen at networkplumber.org
Wed Feb 20 16:46:49 CET 2019


On Wed, 20 Feb 2019 12:52:54 +0100
Jakub Grajciar <jgrajcia at cisco.com> wrote:

> +static int
> +memif_msg_receive_add_ring(struct rte_eth_dev *dev, memif_msg_t *msg, int fd)
> +{
> +	struct pmd_internals *pmd = dev->data->dev_private;
> +	memif_msg_add_ring_t *ar = &msg->add_ring;
> +
> +	if (fd < 0) {
> +		memif_msg_enq_disconnect(pmd->cc, "Missing interrupt fd", 0);
> +		return -1;
> +	}
> +
> +	struct memif_queue *mq;

Minor nit. Please avoid doing c99 style declarations and move this line up to
start of the function.


More information about the dev mailing list