[dpdk-dev] [PATCH] compat: merge compat library into EAL

David Marchand david.marchand at redhat.com
Thu Jan 10 13:28:54 CET 2019


On Thu, Jan 10, 2019 at 12:12 PM Bruce Richardson <
bruce.richardson at intel.com> wrote:

> Since compat library is only a single header, we can easily move it into
> the EAL common headers instead of tracking it separately. The downside of
> this is that it becomes a little more difficult to have any libs that are
> built before EAL depend on it. Thankfully, this is not the case, so there
> are no big complications to the move.
>
> However, to ensure that we don't later hit problems later with this, we can
> add EAL common headers folder to the global include list in the meson build
> which means that all common headers can be safely used by all libraries, no
> matter what their build order.
>
> Signed-off-by: Bruce Richardson <bruce.richardson at intel.com>
>

Currently testing this patch, I just noticed some remaining traces of
librte_compat:

[dmarchan at dmarchan dpdk]$ git grep librte_compat
MAINTAINERS:F: lib/librte_compat/
doc/api/doxy-api.conf.in:                          @TOPDIR@/lib/librte_compat
\
doc/guides/contributing/documentation.rst:   |-- librte_compat
doc/guides/contributing/versioning.rst:To support backward compatibility
the ``lib/librte_compat/rte_compat.h``

and librte_compat_netmap does not exist:
examples/netmap_compat/bridge/bridge.c:                 "Couldn't
initialize librte_compat_netmap\n");
examples/netmap_compat/bridge/bridge.c:
printf("librte_compat_netmap initialized\n");


-- 
David Marchand


More information about the dev mailing list