[dpdk-dev] [RFC 1/5] eal: add the APIs to wait until equal

Thomas Monjalon thomas at monjalon.net
Mon Jul 1 09:43:27 CEST 2019


01/07/2019 09:16, Gavin Hu (Arm Technology China):
> From: Stephen Hemminger <stephen at networkplumber.org>
> > Gavin Hu <gavin.hu at arm.com> wrote:
> > 
> > > +#ifdef RTE_USE_WFE
> > > +#define rte_wait_until_equal_relaxed(addr, expected) do {\
[...]
> > That is a hot mess.
> > Macro's are harder to maintain and offer no benefit over inline functions.
> 
> During our internal review, I ever used C11 _Generic to generalize the API to take different types of arguments. 

Gavin, the question is about macros versus functions.
Please, could you convert it into an inline function?





More information about the dev mailing list