[dpdk-dev] [PATCH v7 07/12] net/bonding: use new ethernet address parser
Stephen Hemminger
stephen at networkplumber.org
Wed Jul 3 00:12:42 CEST 2019
The cmdline library used to be the only way to parse a
mac address. Now there is rte_ether_unformat_addr.
Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
---
drivers/net/bonding/Makefile | 2 +-
drivers/net/bonding/meson.build | 2 +-
drivers/net/bonding/rte_eth_bond_args.c | 6 +-----
3 files changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/net/bonding/Makefile b/drivers/net/bonding/Makefile
index 1893e3cad313..26c1782554cd 100644
--- a/drivers/net/bonding/Makefile
+++ b/drivers/net/bonding/Makefile
@@ -12,7 +12,7 @@ CFLAGS += -DALLOW_EXPERIMENTAL_API
CFLAGS += -O3
CFLAGS += $(WERROR_FLAGS)
LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring
-LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs -lrte_cmdline
+LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs
LDLIBS += -lrte_pci -lrte_bus_pci
LDLIBS += -lrte_bus_vdev
diff --git a/drivers/net/bonding/meson.build b/drivers/net/bonding/meson.build
index 00374edb2a9d..6267210adf5f 100644
--- a/drivers/net/bonding/meson.build
+++ b/drivers/net/bonding/meson.build
@@ -8,6 +8,6 @@ sources = files('rte_eth_bond_api.c', 'rte_eth_bond_pmd.c', 'rte_eth_bond_flow.c
'rte_eth_bond_args.c', 'rte_eth_bond_8023ad.c', 'rte_eth_bond_alb.c')
deps += 'sched' # needed for rte_bitmap.h
-deps += ['ip_frag', 'cmdline']
+deps += ['ip_frag']
install_headers('rte_eth_bond.h', 'rte_eth_bond_8023ad.h')
diff --git a/drivers/net/bonding/rte_eth_bond_args.c b/drivers/net/bonding/rte_eth_bond_args.c
index 01bbb06c1a84..936440fb8491 100644
--- a/drivers/net/bonding/rte_eth_bond_args.c
+++ b/drivers/net/bonding/rte_eth_bond_args.c
@@ -7,9 +7,6 @@
#include <rte_bus_pci.h>
#include <rte_kvargs.h>
-#include <cmdline_parse.h>
-#include <cmdline_parse_etheraddr.h>
-
#include "rte_eth_bond.h"
#include "rte_eth_bond_private.h"
@@ -281,8 +278,7 @@ bond_ethdev_parse_bond_mac_addr_kvarg(const char *key __rte_unused,
return -1;
/* Parse MAC */
- return cmdline_parse_etheraddr(NULL, value, extra_args,
- sizeof(struct rte_ether_addr));
+ return rte_ether_unformat_addr(value, extra_args);
}
int
--
2.20.1
More information about the dev
mailing list