[dpdk-dev] [RFC PATCH] bus/pci: avoid depending on private value in kernel source

David Marchand david.marchand at redhat.com
Wed Jul 3 09:02:59 CEST 2019


Hello,

On Wed, Jul 3, 2019 at 7:47 AM Tiwei Bie <tiwei.bie at intel.com> wrote:

> The value 40 used in VFIO_GET_REGION_ADDR() is a private value
> (VFIO_PCI_OFFSET_SHIFT) defined in Linux kernel source [1]. It
> is not part of VFIO API, and we should not depend on it.
>
> [1]
> https://github.com/torvalds/linux/blob/6fbc7275c7a9/drivers/vfio/pci/vfio_pci_private.h#L19
>
>
I did not follow linux kernel changes, is there something that would change
this offset?
It looks like a cleanup (did not look into the details yet), do we need
this now?


-- 
David Marchand


More information about the dev mailing list