[dpdk-dev] [PATCH 3/3] event/opdl: fix to set positive rte_errno
David Marchand
david.marchand at redhat.com
Thu Jul 4 13:41:45 CEST 2019
On Thu, Jul 4, 2019 at 12:04 PM Andrew Rybchenko <arybchenko at solarflare.com>
wrote:
> From: Dilshod Urazov <Dilshod.Urazov at oktetlabs.ru>
>
> Fixes: 0bf298e39286 ("event/opdl: add event port config get/set")
> Fixes: 3c7f3dcfb099 ("event/opdl: add PMD main body and helper function")
> Fixes: 4236ce9bf5bf ("event/opdl: add OPDL ring infrastructure library")
> Cc: stable at dpdk.org
>
> Signed-off-by: Dilshod Urazov <Dilshod.Urazov at oktetlabs.ru>
> Signed-off-by: Andrew Rybchenko <arybchenko at solarflare.com>
> ---
> drivers/event/opdl/opdl_evdev.c | 10 +++++-----
> drivers/event/opdl/opdl_evdev_init.c | 12 ++++++------
> drivers/event/opdl/opdl_ring.c | 2 +-
> 3 files changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/event/opdl/opdl_evdev.c
> b/drivers/event/opdl/opdl_evdev.c
> index d2d2be4..3beca89 100644
> --- a/drivers/event/opdl/opdl_evdev.c
> +++ b/drivers/event/opdl/opdl_evdev.c
> @@ -102,7 +102,7 @@
> dev->data->dev_id,
> queues[0],
> p->id);
> - rte_errno = -EINVAL;
> + rte_errno = EINVAL;
> return 0;
> }
>
> @@ -113,7 +113,7 @@
> dev->data->dev_id,
> num,
> p->id);
> - rte_errno = -EDQUOT;
> + rte_errno = EDQUOT;
> return 0;
> }
>
> @@ -123,7 +123,7 @@
> dev->data->dev_id,
> p->id,
> queues[0]);
> - rte_errno = -EINVAL;
> + rte_errno = EINVAL;
> return 0;
> }
>
> @@ -134,7 +134,7 @@
> p->id,
> p->external_qid,
> queues[0]);
> - rte_errno = -EINVAL;
> + rte_errno = EINVAL;
> return 0;
> }
>
> @@ -160,7 +160,7 @@
> dev->data->dev_id,
> queues[0],
> p->id);
> - rte_errno = -EINVAL;
> + rte_errno = EINVAL;
> return 0;
> }
> RTE_SET_USED(nb_unlinks);
> diff --git a/drivers/event/opdl/opdl_evdev_init.c
> b/drivers/event/opdl/opdl_evdev_init.c
> index 582ad69..15aae47 100644
> --- a/drivers/event/opdl/opdl_evdev_init.c
> +++ b/drivers/event/opdl/opdl_evdev_init.c
> @@ -35,7 +35,7 @@
> p->id,
> ev[i].queue_id,
> p->next_external_qid);
> - rte_errno = -EINVAL;
> + rte_errno = EINVAL;
> return 0;
> }
> }
> @@ -63,7 +63,7 @@
> } else {
> if (num > 0 &&
> ev[0].queue_id != p->next_external_qid) {
> - rte_errno = -EINVAL;
> + rte_errno = EINVAL;
> return 0;
> }
> }
> @@ -116,7 +116,7 @@
> RTE_SET_USED(ev);
> RTE_SET_USED(num);
>
> - rte_errno = -ENOSPC;
> + rte_errno = ENOSPC;
>
> return 0;
> }
> @@ -145,7 +145,7 @@
>
>
> if (enqueued < num)
> - rte_errno = -ENOSPC;
> + rte_errno = ENOSPC;
>
> return enqueued;
> }
> @@ -164,7 +164,7 @@
> RTE_SET_USED(ev);
> RTE_SET_USED(num);
>
> - rte_errno = -ENOSPC;
> + rte_errno = ENOSPC;
>
> return 0;
> }
> @@ -240,7 +240,7 @@
> "Attempt to dequeue num of events larger than
> port (%d) max",
> opdl_pmd_dev_id(p->opdl),
> p->id);
> - rte_errno = -EINVAL;
> + rte_errno = EINVAL;
> return 0;
> }
>
> diff --git a/drivers/event/opdl/opdl_ring.c
> b/drivers/event/opdl/opdl_ring.c
> index e988f1c..e8b29e2 100644
> --- a/drivers/event/opdl/opdl_ring.c
> +++ b/drivers/event/opdl/opdl_ring.c
> @@ -756,7 +756,7 @@ struct opdl_ring {
> opdl_stage_disclaim(struct opdl_stage *s, uint32_t num_entries, bool
> block)
> {
> if (num_entries != s->num_event) {
> - rte_errno = -EINVAL;
> + rte_errno = EINVAL;
> return 0;
> }
> if (s->threadsafe == false) {
> --
> 1.8.3.1
>
Reviewed-by: David Marchand <david.marchand at redhat.com>
--
David Marchand
More information about the dev
mailing list