[dpdk-dev] [PATCH] examples/ipsec-secgw: fix to set positive rte_errno

[Andrew Rybchenko]

On 05.07.2019 16:46, Iremonger, Bernard wrote:
> Hi Andrew, Dilshod
>
>> -----Original Message-----
>> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Andrew Rybchenko
>> Sent: Friday, July 5, 2019 1:18 PM
>> To: Nicolau, Radu <radu.nicolau at intel.com>; Akhil Goyal
>> <akhil.goyal at nxp.com>
>> Cc: dev at dpdk.org; Dilshod Urazov <Dilshod.Urazov at oktetlabs.ru>;
>> stable at dpdk.org
>> Subject: [dpdk-dev] [PATCH] examples/ipsec-secgw: fix to set positive
>> rte_errno
>>
>> From: Dilshod Urazov <Dilshod.Urazov at oktetlabs.ru>
>>
>> Fixes: d299106e8e31 ("examples/ipsec-secgw: add IPsec sample application")
>> Cc: stable at dpdk.org
>>
>> Signed-off-by: Dilshod Urazov <Dilshod.Urazov at oktetlabs.ru>
>> Signed-off-by: Andrew Rybchenko <arybchenko at solarflare.com>
>> ---
>>   examples/ipsec-secgw/sa.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/examples/ipsec-secgw/sa.c b/examples/ipsec-secgw/sa.c index
>> 8d47d1def..8044066a8 100644
>> --- a/examples/ipsec-secgw/sa.c
>> +++ b/examples/ipsec-secgw/sa.c
>> @@ -739,7 +739,7 @@ sa_create(const char *name, int32_t socket_id)
>>   			RTE_MEMZONE_1GB |
>> RTE_MEMZONE_SIZE_HINT_ONLY);
>>   	if (mz == NULL) {
>>   		printf("Failed to allocate SA DB memory\n");
>> -		rte_errno = -ENOMEM;
>> +		rte_errno = ENOMEM;
>>   		return NULL;
>>   	}
>>
>> --
>> 2.17.1
> ./devtools/check-git-log.sh -1
> Wrong headline format:
>          examples/ipsec-secgw: fix to set positive rte_errno
>
> Otherwise
> Acked-by: Bernard Iremonger <bernard.iremonger at intel.com>

It does not like underscore in headline. I think in this case it is 
better to
keep it as is instead of trying to describe rte_errno is a different way.

Thanks.