[dpdk-dev] [PATCH v2 5/5] mempool/dpaa2: vfio dmamap for user allocated memory

Thomas Monjalon thomas at monjalon.net
Sun Jul 7 21:55:01 CEST 2019


Hi, please see several comments about formatting below.

The title should start with a verb.
VFIO and DMA should be uppercase.

27/06/2019 11:33, Hemant Agrawal:
> From: Sachin Saxena <sachin.saxena at nxp.com>
> 
> Signed-off-by: Sachin Saxena <sachin.saxena at nxp.com>

There is no description in this patch.

> --- a/drivers/bus/fslmc/fslmc_vfio.c
> +++ b/drivers/bus/fslmc/fslmc_vfio.c
> +__rte_experimental
> +int rte_fslmc_vfio_mem_dmamap(uint64_t vaddr, uint64_t iova, uint64_t size)

The new policy forbids __rte_experimental tag in .c file.
Per coding style, the return type should be on a separate line.





More information about the dev mailing list