[dpdk-dev] [PATCH v4 1/3] lib/librte_ip_frag: remove IP checkum offload flag

Thomas Monjalon thomas at monjalon.net
Mon Jul 8 11:07:27 CEST 2019


08/07/2019 06:32, jerinj at marvell.com:
> From: Sunil Kumar Kori <skori at marvell.com>
> 
> Currently PKT_TX_IP_CKSUM is being set into mbuf->ol_flags
> during fragmentation and reassemble operation implicitly.
> Because of this, application is forced to use checksum offload
> whether it is supported by platform or not.
> 
> Also documentation does not provide any expected value of ol_flags
> in returned mbuf (reassembled or fragmented) so application will never
> come to know that which offloads are enabled. So transmission may be failed
> for the platforms which does not support checksum offload.
> 
> Also, IPv6 does not contain any checksum field in header so setting
> mbuf->ol_flags with PKT_TX_IP_CKSUM is itself invalid.
> 
> So removing mentioned flag from the library.
> 
> Signed-off-by: Sunil Kumar Kori <skori at marvell.com>
> Acked-by: Konstantin Ananyev <konstantin.ananyev at intel.com>

Applied, thanks

PS: I move the release notes from ABI to API changes
as it is an API behaviour change.




More information about the dev mailing list