[dpdk-dev] [PATCH v2 0/2] lib/hash: perf improvements for lock-free

Wang, Yipeng1 yipeng1.wang at intel.com
Mon Jul 8 18:51:26 CEST 2019


>-----Original Message-----
>From: Thomas Monjalon [mailto:thomas at monjalon.net]
>Sent: Thursday, July 4, 2019 9:10 AM
>To: Honnappa Nagarahalli <honnappa.nagarahalli at arm.com>
>Cc: dev at dpdk.org; Wang, Yipeng1 <yipeng1.wang at intel.com>; Gobriel, Sameh <sameh.gobriel at intel.com>; Richardson, Bruce
><bruce.richardson at intel.com>; De Lara Guarch, Pablo <pablo.de.lara.guarch at intel.com>; gavin.hu at arm.com;
>ruifeng.wang at arm.com; nd at arm.com
>Subject: Re: [dpdk-dev] [PATCH v2 0/2] lib/hash: perf improvements for lock-free
>
>02/07/2019 23:16, Honnappa Nagarahalli:
>> v2
>>  - Dropped moving the tbl_chng_cnt to the beginning of the cache line
>>    commit
>>  - Changed the commit log for patch 1 to indicate that it improves
>>    performance (Yipeng)
>>  - Changed the comment in the search_one_bucket_lf function (Yipeng)
>>  - Changed the commit log for patch2 to indicate that changes to
>>    store-release of 'pdata' is cosmetic (Yipeng)
>>
>> Honnappa Nagarahalli (2):
>>   lib/hash: use ordered loads only if signature matches
>>   lib/hash: load pData after full key compare
>
>This series is missing 19.08 because of a lack of review.
>It was expected because it was sent late in 19.08 cycle,
>so this is just to make the status clear: it will be considered for 19.11.
>
>PS: please think about --in-reply-to when sending new versions.
>
[Wang, Yipeng] Hi, Thomas, Thanks for your work.
I finished the review of this patch, I think it is good to go. Please include it if it is convenient for you.
Honnappa confirmed that my understanding of the code is correct, and it should help performance.



More information about the dev mailing list