[dpdk-dev] [PATCH v9 09/11] net/failsafe: use common ether address parsing routine
Stephen Hemminger
stephen at networkplumber.org
Mon Jul 8 20:26:12 CEST 2019
Use rte_ether_unformat_addr rather than sscanf.
Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
Acked-by: Gaetan Rivet <gaetan.rivet at 6wind.com>
---
drivers/net/failsafe/failsafe_args.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/net/failsafe/failsafe_args.c b/drivers/net/failsafe/failsafe_args.c
index d2e725bcea13..707490b94c4e 100644
--- a/drivers/net/failsafe/failsafe_args.c
+++ b/drivers/net/failsafe/failsafe_args.c
@@ -368,15 +368,11 @@ fs_get_mac_addr_arg(const char *key __rte_unused,
const char *value, void *out)
{
struct rte_ether_addr *ea = out;
- int ret;
if ((value == NULL) || (out == NULL))
return -EINVAL;
- ret = sscanf(value, "%hhx:%hhx:%hhx:%hhx:%hhx:%hhx",
- &ea->addr_bytes[0], &ea->addr_bytes[1],
- &ea->addr_bytes[2], &ea->addr_bytes[3],
- &ea->addr_bytes[4], &ea->addr_bytes[5]);
- return ret != RTE_ETHER_ADDR_LEN;
+
+ return rte_ether_unformat_addr(value, ea);
}
int
--
2.20.1
More information about the dev
mailing list