[dpdk-dev] [dpdk-stable] [PATCH v3 1/2] metrics: new API to deinitialise metrics library

Thomas Monjalon thomas at monjalon.net
Thu Jul 11 00:08:09 CEST 2019


10/07/2019 12:52, Harman Kalra:
> Once the library usage is over, it must be deinitialized which
> will free the shared memory reserved during initialization.
> 
> Observed an issue while running 'metrics_autotest' continuously
> without quiting. For the first run 'metrics_autotest' passes
> all test cases but second run onwards first test case fails
> because metrics library is already initialized during first run.
> 
> Cc: stable at dpdk.org
> 
> Signed-off-by: Harman Kalra <hkalra at marvell.com>
> ---
> v2:
> * Adding stable at dpdk.org into cc as this patch falls between bug fix
> and new feature.
> v3:
> * Fixed check-git-log.sh and make doc-guides-html issues.

Why don't you take our comments into account?

Reminder 1:
"
I was waiting for an ack on this patch,
and realized that there was one already on v1.
When sending v2, you should have reported the Ack.
"

Reminder 2:
"
Tested-by : Reshma Pattan <reshma.pattan at intel.com>
Reviewed-by: Reshma Pattan <reshma.pattan at intel.com>
Acked-by: Reshma Pattan <reshma.pattan at intel.com>

Please keep these tags for next versions.
"

Reminder 3:
"
I would vote for not backporting this new API.
"

In case it is not clear, this comment means you should not Cc stable at dpdk.org




More information about the dev mailing list