[dpdk-dev] [PATCH] net/ice: fixed wrong return value

[Yang, Qiming]

Hi, Thomas
Thanks for the comments. Will change it.

Qiming
-----Original Message-----
From: Thomas Monjalon [mailto:thomas at monjalon.net] 
Sent: Wednesday, July 10, 2019 3:30 PM
To: Yang, Qiming <qiming.yang at intel.com>
Cc: dev at dpdk.org; Yigit, Ferruh <ferruh.yigit at intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/ice: fixed wrong return value

Hi,

09/07/2019 06:08, Qiming Yang:
> Fixed error return value check and wrong error message.
> 
> Fixes: d76116a4678f ("net/ice: add generic flow API")
> 
> Signed-off-by: Qiming Yang <qiming.yang at intel.com>

Comments about the formatting of the title:

The verb must be in infinitive form: "fix".

The title must say which behaviour is fixed, not the code detail (we don't care in the title if it because of a return value or variable assignment).
Here it is about fixing flow rule validation, right?

One more thing, the word "wrong" can always be avoided after "fix", because we know you are not fixing something which worked perfectly :)

Do not hesitate to share these tips around you.
Thank you