[dpdk-dev] [PATCH 1/2] timer: fix null pointer dereference

Stephen Hemminger stephen at networkplumber.org
Mon Jul 15 17:48:41 CEST 2019


On Mon, 15 Jul 2019 10:39:31 -0500
Erik Gabriel Carrillo <erik.g.carrillo at intel.com> wrote:

> If the timer subsystem is not initialized before rte_timer_manage (for
> example) is invoked, a pointer to a shared hugepage memory region will
> still be null and dereferenced when it is checked for validity; handle
> this case.
> 
> Fixes: c0749f7096c7 ("timer: allow management in shared memory")
> Cc: stable at dpdk.org
> 
> Signed-off-by: Erik Gabriel Carrillo <erik.g.carrillo at intel.com>

I have mixed feelings about this patch.
Any calls to rte_timer before rte_timer_subsystem_init is not a
valid usage. Better to kill the application.


More information about the dev mailing list