[dpdk-dev] [RFC PATCH] vfio: avoid re-installing irq handler

Jerin Jacob Kollanukkaran jerinj at marvell.com
Mon Jul 15 18:50:35 CEST 2019


> -----Original Message-----
> From: Hyong Youb Kim <hyonkim at cisco.com>
> Sent: Monday, July 15, 2019 9:28 PM
> To: David Marchand <david.marchand at redhat.com>; Thomas Monjalon
> <thomas at monjalon.net>; Jerin Jacob Kollanukkaran <jerinj at marvell.com>;
> Ferruh Yigit <ferruh.yigit at intel.com>
> Cc: dev at dpdk.org; John Daley <johndale at cisco.com>; Hyong Youb Kim
> <hyonkim at cisco.com>
> Subject: [EXT] [RFC PATCH] vfio: avoid re-installing irq handler
> 
> A rough patch for the approach mentioned earlier. It is only for discussion.
> http://mails.dpdk.org/archives/dev/2019-July/138113.html
> 
> To try this out, first revert the following then apply.
> commit 89aac60e0be9 ("vfio: fix interrupts race condition")

Yes. This patch has to be to reverted. It changes the existing interrupt behavior and does not address the MSIX case as well.

I think, The clean fix would be to introduce rte_intr_mask() and rte_intr_unmask() by abstracting the INTX and MSIX differences
And let qede driver call it as needed.

Thoughts?


More information about the dev mailing list