[dpdk-dev] [PATCH] lib/librte_ip_frag: Remove PKT_TX_IP_CKSUM offload flags

Jerin Jacob Kollanukkaran jerinj at marvell.com
Tue Jul 16 07:41:55 CEST 2019


> -----Original Message-----
> From: Thomas Monjalon <thomas at monjalon.net>
> Sent: Tuesday, July 16, 2019 3:35 AM
> To: Sunil Kumar Kori <skori at marvell.com>; Jerin Jacob Kollanukkaran
> <jerinj at marvell.com>
> Cc: dev at dpdk.org; Konstantin Ananyev <konstantin.ananyev at intel.com>
> Subject: Re: [dpdk-dev] [PATCH] lib/librte_ip_frag: Remove
> PKT_TX_IP_CKSUM offload flags
> 
> 15/07/2019 10:17, Sunil Kumar Kori:
> > Current patch is part of following patchset
> > http://patches.dpdk.org/patch/53475/
> > which is missed to be merged into upstream because of accepted version
> > of this patch does not contain this change.
> >
> > Accepted patchset is given below:
> > http://patches.dpdk.org/patch/56202/
> >
> > Patchset is already reviewed and acked on maillist. Also
> > corrersponding release notes are updated.
> [..]
> > --- a/lib/librte_ip_frag/rte_ipv4_fragmentation.c
> > +++ b/lib/librte_ip_frag/rte_ipv4_fragmentation.c
> > -		out_pkt->ol_flags |= PKT_TX_IP_CKSUM;
> >  		out_pkt->l3_len = sizeof(struct rte_ipv4_hdr);
> 
> Jerin, what happened? A part of the patch was missing?

Yes. It was my bad. On rebase to top of tree, due to rename of ipv4_hdr to rte_ipv4_hdr and similar,
Those patches need to be manually rebased.

> Is this patch really required?

Yes.

> If this patch is required, the commit log must be changed.

Yes.

> 



More information about the dev mailing list