[dpdk-dev] [PATCH v9 1/2] ring: add reset API to flush the ring when not in use

Thomas Monjalon thomas at monjalon.net
Tue Jul 16 17:06:53 CEST 2019


16/07/2019 16:03, Gavin Hu (Arm Technology China):
> From: Olivier Matz <olivier.matz at 6wind.com>
> > On Tue, Jul 16, 2019 at 11:01:21AM +0200, Olivier Matz wrote:
> > > On Fri, Jul 12, 2019 at 11:54:36PM +0800, Gavin Hu wrote:
> > > > Currently, the flush is done by dequeuing the ring in a while loop. It is
> > > > much simpler to flush the queue by resetting the head and tail indices.
> > > >
> > > > Fixes: af75078fece3 ("first public release")
> > > > Cc: stable at dpdk.org
> > 
> > Actually it's not a fix, it adds a new API.
> > 
> > Is the patch in hash library intended to be backported? If yes, as it
> > seems to be a performance optimization, you'll need to describe what
> > scenario you're fixing and what is the performance gain. If no, the Cc
> > stable can be removed.
> 
> As this is not in the data plan, I don't intend to backport. 
> Do I need to submit a new version to remove the CC: lines? 

Yes please.
You can also remove the "fixes" line in the first patch.




More information about the dev mailing list