[dpdk-dev] [EXT] [PATCH] net/octeontx: use logtype_init for failed probe

Jerin Jacob Kollanukkaran jerinj at marvell.com
Fri Jul 19 05:37:26 CEST 2019



> -----Original Message-----
> From: Stephen Hemminger <stephen at networkplumber.org>
> Sent: Wednesday, July 17, 2019 12:18 AM
> To: Jerin Jacob Kollanukkaran <jerinj at marvell.com>
> Cc: dev at dpdk.org
> Subject: [EXT] [PATCH] net/octeontx: use logtype_init for failed probe

> All log messages should use driver logtype. RTE_LOGTYPE_PMD is planned to
> be deprecated in the future.
> 
> Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
> ---

Please fix

$ ./devtools/check-git-log.sh
Wrong headline format:
        net/octeontx: use logtype_init for failed probe
		
		

>  drivers/net/octeontx/octeontx_ethdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/octeontx/octeontx_ethdev.c
> b/drivers/net/octeontx/octeontx_ethdev.c
> index 1b853399dfe4..27eed47bb0cb 100644
> --- a/drivers/net/octeontx/octeontx_ethdev.c
> +++ b/drivers/net/octeontx/octeontx_ethdev.c
> @@ -1175,7 +1175,7 @@ octeontx_probe(struct rte_vdev_device *dev)
>  	    strlen(rte_vdev_device_args(dev)) == 0) {
>  		eth_dev = rte_eth_dev_attach_secondary(dev_name);
>  		if (!eth_dev) {
> -			RTE_LOG(ERR, PMD, "Failed to probe %s\n",
> dev_name);
> +			PMD_INIT_LOG(ERR, "Failed to probe %s",
> dev_name);
>  			return -1;
>  		}
>  		/* TODO: request info from primary to set up Rx and Tx */
> --
> 2.20.1



More information about the dev mailing list