[dpdk-dev] [RFC] mark asym session-buffer non-reuseable

[Trahe, Fiona]

No need as API is still experimental.

Howver I'd suggest changing the subject to
"declare crypto asym xform immutable"
non-reusable is confusing as the session and xform will be re-used on all the ops associated with the session.

From: Ayuj Verma [mailto:ayverma at marvell.com]
Sent: Friday, July 19, 2019 3:51 PM
To: Kusztal, ArkadiuszX <arkadiuszx.kusztal at intel.com>; akhil.goyal at nxp.com
Cc: Trahe, Fiona <fiona.trahe at intel.com>; Shally Verma <shallyv at marvell.com>; Sunila Sahu <ssahu at marvell.com>; Kanaka Durga Kotamarthy <kkotamarthy at marvell.com>; dev at dpdk.org
Subject: Re: [RFC] mark asym session-buffer non-reuseable


Hi Akhil, Arek, Fiona,



Since this require changes in other Asym PMD( qat) apart from openssl (we plan to send changes for this),

so should we need to send any announcement on ABI breakage here before proposing patch v1?



Thanks and regards

Ayuj Verma

________________________________
From: Ayuj Verma
Sent: 18 July 2019 15:17:54
To: Kusztal, ArkadiuszX; akhil.goyal at nxp.com<mailto:akhil.goyal at nxp.com>
Cc: Trahe, Fiona; Shally Verma; Sunila Sahu; Kanaka Durga Kotamarthy; dev at dpdk.org<mailto:dev at dpdk.org>
Subject: Re: [RFC] mark asym session-buffer non-reuseable


Hi Arek,



Please see inline.



Thanks and regards

Ayuj Verma

________________________________
From: Kusztal, ArkadiuszX <arkadiuszx.kusztal at intel.com<mailto:arkadiuszx.kusztal at intel.com>>
Sent: 17 July 2019 19:40
To: Ayuj Verma; akhil.goyal at nxp.com<mailto:akhil.goyal at nxp.com>
Cc: Trahe, Fiona; Shally Verma; Sunila Sahu; Kanaka Durga Kotamarthy; dev at dpdk.org<mailto:dev at dpdk.org>
Subject: RE: [RFC] mark asym session-buffer non-reuseable

Hi Ayuj,

> -----Original Message-----
> From: Ayuj Verma [mailto:ayverma at marvell.com]
> Sent: Wednesday, July 17, 2019 2:34 PM
> To: akhil.goyal at nxp.com<mailto:akhil.goyal at nxp.com>
> Cc: Kusztal, ArkadiuszX <arkadiuszx.kusztal at intel.com<mailto:arkadiuszx.kusztal at intel.com>>; Trahe, Fiona
> <fiona.trahe at intel.com<mailto:fiona.trahe at intel.com>>; shallyv at marvell.com<mailto:shallyv at marvell.com>; ssahu at marvell.com<mailto:ssahu at marvell.com>;
> kkotamarthy at marvell.com<mailto:kkotamarthy at marvell.com>; dev at dpdk.org<mailto:dev at dpdk.org>; Ayuj Verma
> <ayverma at marvell.com<mailto:ayverma at marvell.com>>
> Subject: [RFC] mark asym session-buffer non-reuseable
>
> This RFC proposes changes in asymmetric session usability of transform
> structure. In current implementation asym xform is seen as temporary entity
> that can be re-used by application once sessions are initialized with it.
>
> This enforces PMD to copy all key buffers during session setup time. Since
> life-time of sessions are small, so we can hold these buffers with session,
[AK] - what is you expected session lifetime? (2,3,50 packets?)
[Ayuj] In practical scenario like SSL, handshake will happen in some 10-15 packets.
> reducing memcpy time by marking these as read-only so that PMDs which
> doesn't require any manipulation of xform data can directly use these
> buffers in session configure.
>
> So, sending a proposal to mark xform as non-reusable till lifetime of session.
> This will help PMDs to reduce session setup time.
>
> Ayuj Verma (1):
>   lib/crypto: mark asym session-buffer non-reuseable
>
>  doc/guides/prog_guide/cryptodev_lib.rst  | 6 ++++++
> lib/librte_cryptodev/rte_cryptodev_pmd.h | 2 +-
>  2 files changed, 7 insertions(+), 1 deletion(-)
>
> --
> 1.8.3.1