[dpdk-dev] [RFC 1/4] mempool: clarify default populate function

Andrew Rybchenko arybchenko at solarflare.com
Fri Jul 19 17:42:06 CEST 2019


On 7/19/19 4:38 PM, Olivier Matz wrote:
> No functional change. Clarify the populate function to make
> the next commit easier to understand.
>
> Rename the variables:
> - to avoid negation in the name
> - to have more understandable names
>
> Remove useless variable (no_pageshift is equivalent to pg_sz == 0).
>
> Remove duplicate affectation of "external" variable.
>
> Signed-off-by: Olivier Matz <olivier.matz at 6wind.com>

LGTM

Reviewed-by: Andrew Rybchenko <arybchenko at solarflare.com>



More information about the dev mailing list