[dpdk-dev] [PATCH] net/mlx5: fix Rx queue release of resources

Raslan Darawsheh rasland at mellanox.com
Wed Jul 24 09:53:40 CEST 2019


Hi Dekel,

> -----Original Message-----
> From: dev <dev-bounces at dpdk.org> On Behalf Of Dekel Peled
> Sent: Tuesday, July 23, 2019 6:35 PM
> To: Yongseok Koh <yskoh at mellanox.com>; Slava Ovsiienko
> <viacheslavo at mellanox.com>; Shahaf Shuler <shahafs at mellanox.com>
> Cc: Ori Kam <orika at mellanox.com>; dev at dpdk.org
> Subject: [dpdk-dev] [PATCH] net/mlx5: fix Rx queue release of resources
> 
> Function rxq_release_rq_resources() releases resources of RQ object
> created by DevX API.
> 
> This patch updates this function to properly clear the released resources, to
> avoid repeated release of the same resource.
> 
> Fixes: 69abf7b1db4a ("net/mlx5: create advanced RxQ using new API")
> 

Wrong 'Fixes' reference:
        Fixes: 69abf7b1db4a ("net/mlx5: create advanced RxQ using new API")

> Signed-off-by: Dekel Peled <dekelp at mellanox.com>
> ---
>  drivers/net/mlx5/mlx5_rxq.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c
> index c9df8b0..441f158 100644
> --- a/drivers/net/mlx5/mlx5_rxq.c
> +++ b/drivers/net/mlx5/mlx5_rxq.c
> @@ -573,8 +573,10 @@
>  		rte_free((void *)(uintptr_t)rxq_ctrl->rxq.wqes);
>  		rxq_ctrl->rxq.wqes = NULL;
>  	}
> -	if (rxq_ctrl->wq_umem)
> +	if (rxq_ctrl->wq_umem) {
>  		mlx5_glue->devx_umem_dereg(rxq_ctrl->wq_umem);
> +		rxq_ctrl->wq_umem = NULL;
> +	}
>  }
> 
>  /**
> --
> 1.8.3.1

Kindest regards,
Raslan Darawsheh


More information about the dev mailing list