[dpdk-dev] [PATCH v2] Revert "eal: fix parsing option --telemetry"

Sean Morrissey sean.morrissey at intel.com
Wed Jul 24 17:20:59 CEST 2019


This reverts commit debacba0297fbe214b4185a9791e6a9fdf6642ba.

Reverting this patch as it currently breaks the initialization of
telemetry, more investigation is ongoing to fix the issue for the
printed error message for unrecognized argument.

Signed-off-by: Sean Morrissey <sean.morrissey at intel.com>
---
v2:
  Adding sign off
---
 lib/librte_eal/common/eal_common_options.c | 3 ---
 lib/librte_eal/common/eal_options.h        | 4 ----
 2 files changed, 7 deletions(-)

diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c
index 24e36cf23..512d5088e 100644
--- a/lib/librte_eal/common/eal_common_options.c
+++ b/lib/librte_eal/common/eal_common_options.c
@@ -81,9 +81,6 @@ eal_long_options[] = {
 	{OPT_LEGACY_MEM,        0, NULL, OPT_LEGACY_MEM_NUM       },
 	{OPT_SINGLE_FILE_SEGMENTS, 0, NULL, OPT_SINGLE_FILE_SEGMENTS_NUM},
 	{OPT_MATCH_ALLOCATIONS, 0, NULL, OPT_MATCH_ALLOCATIONS_NUM},
-#ifdef RTE_LIBRTE_TELEMETRY
-	{OPT_TELEMETRY,         0, NULL, OPT_TELEMETRY_NUM        },
-#endif
 	{0,                     0, NULL, 0                        }
 };
 
diff --git a/lib/librte_eal/common/eal_options.h b/lib/librte_eal/common/eal_options.h
index e4c8e25c2..9855429e5 100644
--- a/lib/librte_eal/common/eal_options.h
+++ b/lib/librte_eal/common/eal_options.h
@@ -69,10 +69,6 @@ enum {
 	OPT_IOVA_MODE_NUM,
 #define OPT_MATCH_ALLOCATIONS  "match-allocations"
 	OPT_MATCH_ALLOCATIONS_NUM,
-#ifdef RTE_LIBRTE_TELEMETRY
-	#define OPT_TELEMETRY          "telemetry"
-		OPT_TELEMETRY_NUM,
-#endif
 	OPT_LONG_MAX_NUM
 };
 
-- 
2.17.1

--------------------------------------------------------------
Intel Research and Development Ireland Limited
Registered in Ireland
Registered Office: Collinstown Industrial Park, Leixlip, County Kildare
Registered Number: 308263


This e-mail and any attachments may contain confidential material for the sole
use of the intended recipient(s). Any review or distribution by others is
strictly prohibited. If you are not the intended recipient, please contact the
sender and delete all copies.



More information about the dev mailing list